Skip to content

Conversation

andreuu-tsai
Copy link

@andreuu-tsai andreuu-tsai commented Sep 5, 2025

Update asyncio.subprocess returncode documentation:

  • For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX).
  • For create_subprocess_shell, the return code follows the invoked shell’s exit status (e.g. 128+N for signals in bash/sh).

📚 Documentation preview 📚: https://cpython-previews--138536.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 5, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are several places in subprocess.rst itself that could be updated in a similar manner to mention the potential difference between shell=False (default) and shell=True.

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting subprocess docs changes and CLA

@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

…hell

Update asyncio.subprocess returncode documentation:
- For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX).
- For create_subprocess_shell, the return code follows the invoked shell’s exit status
  (e.g. 128+N for signals in bash/sh).
@andreuu-tsai andreuu-tsai force-pushed the doc-asyncio-subprocess-returncode-in-shell branch from 5fac6df to 979128f Compare October 6, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants