-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell #138536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-138234: clarify returncode behavior for subprocess_exec vs subprocess_shell #138536
Conversation
b833aaf
to
93cdda2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are several places in subprocess.rst itself that could be updated in a similar manner to mention the potential difference between shell=False
(default) and shell=True
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awaiting subprocess docs changes and CLA
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…hell Update asyncio.subprocess returncode documentation: - For create_subprocess_exec, negative values (-N) indicate termination by signal N (POSIX). - For create_subprocess_shell, the return code follows the invoked shell’s exit status (e.g. 128+N for signals in bash/sh).
5fac6df
to
979128f
Compare
Update asyncio.subprocess returncode documentation:
asyncio.create_subprocess_shell
does not consistently result in negativereturncode
on signal termination #138234📚 Documentation preview 📚: https://cpython-previews--138536.org.readthedocs.build/